Skip to content

Nebula: Fix wallet address not set in context when clicking example prompt on login page #6856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

Nebula: Fix wallet address not set in context when clicking example prompt on login page #6856

merged 1 commit into from
Apr 25, 2025
+27 −9

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 25, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR introduces the retrieval of accountAddress alongside authToken in multiple components, ensuring that the ChatPageContent receives this new prop. It enhances the login validation by checking both tokens before redirecting.

Detailed summary

  • Added accountAddress prop to ChatPageContent in ChatPageContent.tsx.
  • Updated Page function in page.tsx to fetch accountAddress using getNebulaAuthTokenWalletAddress.
  • Modified login validation in page.tsx to check both authToken and accountAddress.
  • Updated page.tsx in the chat session to retrieve accountAddress.
  • Adjusted imports in multiple files to include getNebulaAuthTokenWalletAddress.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 3:03pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 25, 2025 3:03pm
login ⬜️ Skipped (Inspect) Apr 25, 2025 3:03pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 25, 2025 3:03pm
wallet-ui ⬜️ Skipped (Inspect) Apr 25, 2025 3:03pm

@vercel vercel bot temporarily deployed to Preview – login April 25, 2025 13:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 25, 2025 13:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 25, 2025 13:38 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 25, 2025 13:38 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 94949bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review April 25, 2025 13:38
@MananTank MananTank requested review from a team as code owners April 25, 2025 13:38
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 25, 2025
@MananTank Graphite App
Copy link
Member Author

MananTank commented Apr 25, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.31%. Comparing base (3825563) to head (94949bc).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6856   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files         896      896           
  Lines       57024    57024           
  Branches     3968     3968           
=======================================
  Hits        31542    31542           
  Misses      25385    25385           
  Partials       97       97
Flag Coverage Δ
packages 55.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 206 ms (+237.68% 🔺) 1.3 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 351 ms (+85.12% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 73 ms (+1500.89% 🔺) 186 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 33 ms (+1439.3% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 88 ms (+564.64% 🔺) 475 ms

@MananTank MananTank changed the title Nebula: Fix wallet address not set when clicking example prompt on login page Nebula: Fix wallet address not in context set when clicking example prompt on login page Apr 25, 2025
@MananTank MananTank changed the title Nebula: Fix wallet address not in context set when clicking example prompt on login page Nebula: Fix wallet address not set in context when clicking example prompt on login page Apr 25, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 25, 2025 •
edited
Loading

Merge activity

@MananTank
Nebula: Fix wallet address not set in context when clicking example p…
94949bc 
…rompt on login page (#6856)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `ChatPageContent` component by adding the `accountAddress` prop and updates various pages to retrieve and pass this new data. It ensures that both `authToken` and `accountAddress` are validated before proceeding.

### Detailed summary
- Added `accountAddress` prop to `ChatPageContent`.
- Updated `walletAddress` assignment to prioritize `props.accountAddress`.
- Modified `Page` components to fetch `accountAddress` using `getNebulaAuthTokenWalletAddress`.
- Updated authentication checks to validate both `authToken` and `accountAddress`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-25-nebula_fix_wallet_address_not_set_when_clicking_example_prompt_on_login_page branch from 715b921 to 94949bc Compare April 25, 2025 14:57
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 25, 2025 14:57 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 25, 2025 14:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 25, 2025 14:57 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 25, 2025 14:57 Inactive
@graphite-app graphite-app bot merged commit 94949bc into main Apr 25, 2025
23 checks passed
@graphite-app graphite-app bot deleted the 04-25-nebula_fix_wallet_address_not_set_when_clicking_example_prompt_on_login_page branch April 25, 2025 15:04
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 25, 2025 15:04 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 25, 2025 15:04 Inactive
@vercel vercel bot temporarily deployed to Production – login April 25, 2025 15:04 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 25, 2025 15:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @joaquim-verges